feat: custom vesting module to check signer in allow list #387
Conversation
| for _, disabledTypeURL := range pvd.disabledMsgTypeURLs { | ||
| if typeURL == disabledTypeURL { | ||
| // Check if vesting tx signer is 1 | ||
| if len(msg.GetSigners()) != 1 { |
There was a problem hiding this comment.
why are we blocking multisigs?
There was a problem hiding this comment.
As I see, all vesting msgs on cosmos-sdk or evmos only contains 1 signer. WDYT
There was a problem hiding this comment.
ok we can start with that
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@omritoptix isn't it bit redundent to have a dedicated module to keep the permission address? Can't we reuse the whitelisted address from other module? it would be the 3rd place we manage |
|
we need to consider how to enforce it through
|
| ) | ||
|
|
||
| // PermissionedVestingDecorator prevents invalid msg types from being executed | ||
| type PermissionedVestingDecorator struct { |
There was a problem hiding this comment.
not wired in app.go ante handler
There was a problem hiding this comment.
the dymension-rdk doesn't actually have antehandler. So I added it here then on rollapp-evm's app.go, we just need to call the Decorator from here
@mtsitrin yea thought about it initially but imo it's less than ideal for 2 reasons:
|
|
Close and decide to not have vesting module on rdk just for permissioned addresses |
As mentioned in rollapp-evm . We need to custom vesting module for creating a allow list that can create vest account.
The code is taken from cosmos-sdk with a few changes for
allow list.